From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D373DC433FE for ; Tue, 8 Dec 2020 10:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87BF823A9B for ; Tue, 8 Dec 2020 10:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728825AbgLHKMa (ORCPT ); Tue, 8 Dec 2020 05:12:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727992AbgLHKMa (ORCPT ); Tue, 8 Dec 2020 05:12:30 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 008D6C06138C for ; Tue, 8 Dec 2020 02:11:48 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kmZyD-0004Ew-AJ; Tue, 08 Dec 2020 11:11:45 +0100 Date: Tue, 8 Dec 2020 11:11:45 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next 5/5] netfilter: nftables: netlink support for several set element expressions Message-ID: <20201208101145.GB31101@breakpoint.cc> References: <20201207181651.18771-1-pablo@netfilter.org> <20201207181651.18771-6-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207181651.18771-6-pablo@netfilter.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > + if ((tb[NFTA_DYNSET_EXPR] || tb[NFTA_DYNSET_EXPR]) && > + !(set->flags & NFT_SET_EVAL)) > + return -EINVAL; Hmm, same expression on both sides of ||, one of those should have been NFTA_DYNSET_EXPRESSIONS?