From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [conntrack-tools PATCH v2 2/2] conntrackd: external_inject: report inject issues as warning
Date: Tue, 8 Dec 2020 12:50:20 +0100 [thread overview]
Message-ID: <20201208115020.GB26272@salvia> (raw)
In-Reply-To: <160707895903.12188.7283813676910230247.stgit@endurance>
On Fri, Dec 04, 2020 at 11:50:25AM +0100, Arturo Borrero Gonzalez wrote:
> In busy firewalls that run conntrackd in NOTRACK with both internal and external caches disabled,
> external_inject can get lots of traffic. In case of issues injecting or updating conntrack entries
> a log entry will be generated, the infamous inject-addX, inject-updX messages.
>
> But there is nothing end users can do about this error message, which is purely internal. This
> patch is basically cosmetic, relaxing the message from ERROR to WARNING. The information reported
> is also extended a bit. The idea is to leave ERROR messages to issues that would *stop* or
> *prevent* conntrackd from working at all.
>
> Another nice thing to do in the future is to rate-limit this message, which is generated in the
> data path and can easily fill log files. But ideally, the actual root cause would be fixed, and
> there would be no WARNING message reported at all, meaning that all conntrack entries are smoothly
> synced between the firewalls in the cluster. We can work on that later.
Also applied.
next prev parent reply other threads:[~2020-12-08 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 10:49 [conntrack-tools PATCH v2 1/2] .gitignore: add nano swap file Arturo Borrero Gonzalez
2020-12-04 10:50 ` [conntrack-tools PATCH v2 2/2] conntrackd: external_inject: report inject issues as warning Arturo Borrero Gonzalez
2020-12-08 11:50 ` Pablo Neira Ayuso [this message]
2020-12-08 11:50 ` [conntrack-tools PATCH v2 1/2] .gitignore: add nano swap file Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208115020.GB26272@salvia \
--to=pablo@netfilter.org \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).