From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [iptables PATCH v3 0/9] nft: Sorted chain listing et al.
Date: Mon, 14 Dec 2020 14:24:54 +0100 [thread overview]
Message-ID: <20201214132454.GF6484@orbyte.nwl.cc> (raw)
In-Reply-To: <20201210130636.26379-1-phil@nwl.cc>
Hi,
On Thu, Dec 10, 2020 at 02:06:27PM +0100, Phil Sutter wrote:
[...]
> * Drop getters previously introduced along with struct nft_chain to
> reduce size of patch 5. Extracting data from embedded nftnl_chain into
> nft_chain and back if needed is future work.
In addition to a "common" review of my patches, I would like to ask you
to consider patch 5 and the code it adds separately as a direct result
of the premise to not add a sorting function to libnftnl (patch here[1])
in order to keep the library's size small.
A consequent continuation of patch 5 is the implementation of converters
from nftnl_chain to nft_chain and vice versa. While this should reduce
cache size a bit (struct nftnl_chain is pretty big), it adds overhead to
cache fetch and commit operations.
After all, I'm not sure if the direction is feasible given the
code-duplication it caused to manage a list of chains in iptables
instead of using the chain list functionality of libnftnl.
Cheers, Phil
[1] https://lore.kernel.org/netfilter-devel/20200711084505.23825-1-phil@nwl.cc/
prev parent reply other threads:[~2020-12-14 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 13:06 [iptables PATCH v3 0/9] nft: Sorted chain listing et al Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 1/9] nft: Fix selective chain compatibility checks Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 2/9] nft: cache: Introduce nft_cache_add_chain() Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 3/9] nft: Implement nft_chain_foreach() Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 4/9] nft: cache: Move nft_chain_find() over Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 5/9] nft: Introduce struct nft_chain Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 6/9] nft: Introduce a dedicated base chain array Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 7/9] nft: cache: Sort custom chains by name Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 8/9] tests: shell: Drop any dump sorting in place Phil Sutter
2020-12-10 13:06 ` [iptables PATCH v3 9/9] nft: Avoid pointless table/chain creation Phil Sutter
2020-12-14 13:24 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214132454.GF6484@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).