From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH xtables-nft 3/3] xtables-monitor: print packet first
Date: Mon, 14 Dec 2020 17:06:11 +0100 [thread overview]
Message-ID: <20201214160611.GA8710@breakpoint.cc> (raw)
In-Reply-To: <20201214141435.GC28824@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> > switch (nftnl_trace_get_u32(nlt, NFTNL_TRACE_TYPE)) {
> > case NFT_TRACETYPE_RULE:
> > verdict = nftnl_trace_get_u32(nlt, NFTNL_TRACE_VERDICT);
> > - printf(":rule:0x%llx:", (unsigned long long)nftnl_trace_get_u64(nlt, NFTNL_TRACE_RULE_HANDLE));
>
> Quite long long line here. ;)
> How about using PRIx64 in the format string to avoid the cast?
Its just being moved from here...
> > - print_verdict(nlt, verdict);
> >
> > - if (nftnl_trace_is_set(nlt, NFTNL_TRACE_RULE_HANDLE))
> > - trace_print_rule(nlt, arg);
> > if (nftnl_trace_is_set(nlt, NFTNL_TRACE_LL_HEADER) ||
> > nftnl_trace_is_set(nlt, NFTNL_TRACE_NETWORK_HEADER))
> > trace_print_packet(nlt, arg);
> > +
> > + if (nftnl_trace_is_set(nlt, NFTNL_TRACE_RULE_HANDLE)) {
> > + trace_print_hdr(nlt);
> > + printf(":rule:0x%llx:", (unsigned long long)nftnl_trace_get_u64(nlt, NFTNL_TRACE_RULE_HANDLE));
To this location. But sure, I can change it.
prev parent reply other threads:[~2020-12-14 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 15:15 [PATCH xtables-nft 0/3] xt-monitor fixes Florian Westphal
2020-12-12 15:15 ` [PATCH xtables-nft 1/3] xtables-monitor: fix rule printing Florian Westphal
2020-12-14 14:19 ` Phil Sutter
2020-12-12 15:15 ` [PATCH xtables-nft 2/3] xtables-monitor: fix packet family protocol Florian Westphal
2020-12-12 15:15 ` [PATCH xtables-nft 3/3] xtables-monitor: print packet first Florian Westphal
2020-12-14 14:14 ` Phil Sutter
2020-12-14 16:06 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214160611.GA8710@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).