From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH 1/2] set_elem: Use nftnl_data_reg_snprintf()
Date: Mon, 14 Dec 2020 19:30:23 +0100 [thread overview]
Message-ID: <20201214183023.GA9271@salvia> (raw)
In-Reply-To: <20201214180251.11408-1-phil@nwl.cc>
On Mon, Dec 14, 2020 at 07:02:50PM +0100, Phil Sutter wrote:
> Introduce a flag to allow toggling the '0x' prefix when printing data
> values, then use the existing routines to print data registers from
> set_elem code.
Patches LGTM.
You will have to update tests/py too, right?
Thanks.
next prev parent reply other threads:[~2020-12-14 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 18:02 [libnftnl PATCH 1/2] set_elem: Use nftnl_data_reg_snprintf() Phil Sutter
2020-12-14 18:02 ` [libnftnl PATCH 2/2] set_elem: Include key_end data reg in print output Phil Sutter
2020-12-14 18:30 ` Pablo Neira Ayuso [this message]
2020-12-15 10:13 ` [libnftnl PATCH 1/2] set_elem: Use nftnl_data_reg_snprintf() Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214183023.GA9271@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).