From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nftables: introduce table ownership
Date: Mon, 1 Feb 2021 15:13:22 +0100 [thread overview]
Message-ID: <20210201141322.GH12443@breakpoint.cc> (raw)
In-Reply-To: <20210201134813.GA24566@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > At least for systemd use case, there would be a need to allow
> > add/removal of set elements from other user.
>
> Then, probably a flag for this? Such flag would work like this?
>
> - Allow for set element updates (from any process, no ownership).
> - nft flush ruleset skips flushing the set.
> - nft flush set x y flushes the content of this set.
Right, i'd suggest some permission set that tells what is (dis)allowed.
> Would this work for the scenario you describe below?
I think so. We can add this later.
> > > + nft_active_genmask(table, genmask)) {
> > > + if (nlpid && table->nlpid && table->nlpid != nlpid)
> > > + return ERR_PTR(-EPERM);
> > > +
> >
> > i.e., (table->flags & OWNED) && table->nlpid != nlpid)?
> >
> > On netlink sk destruction the owner flag could be cleared or table
> > could be auto-zapped.
>
> Default behaviour right now is: table is released if owner is gone.
I think thats fine.
next prev parent reply other threads:[~2021-02-01 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 2:19 [PATCH nf-next] netfilter: nftables: introduce table ownership Pablo Neira Ayuso
2021-02-01 12:24 ` Florian Westphal
2021-02-01 13:48 ` Pablo Neira Ayuso
2021-02-01 14:13 ` Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-27 1:52 Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201141322.GH12443@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).