From: Pablo Neira Ayuso <pablo@netfilter.org>
To: sven.auhagen@voleatech.de
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: flowtable: fix tcp and udp header checksum update
Date: Wed, 3 Feb 2021 00:29:05 +0100 [thread overview]
Message-ID: <20210202232905.GA29511@salvia> (raw)
In-Reply-To: <20210202170116.8763-1-sven.auhagen@voleatech.de>
Hi Sven,
On Tue, Feb 02, 2021 at 06:01:16PM +0100, sven.auhagen@voleatech.de wrote:
> From: Sven Auhagen <sven.auhagen@voleatech.de>
>
> When updating the tcp or udp header checksum on port nat
> the function inet_proto_csum_replace2 with the last parameter
> pseudohdr as true.
> This leads to an error in the case that GRO is used and packets
> are split up in GSO.
> The tcp or udp checksum of all packets is incorrect.
>
> The error is probably masked due to the fact the most network driver
> implement tcp/udp checksum offloading.
> It also only happens when GRO is applied and not on single packets.
>
> The error is most visible when using a pppoe connection which is not
> triggering the tcp/udp checksum offload.
Good catch.
I'll apply this patch to nf.git.
prev parent reply other threads:[~2021-02-02 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 17:01 [PATCH] netfilter: flowtable: fix tcp and udp header checksum update sven.auhagen
2021-02-02 23:29 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202232905.GA29511@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sven.auhagen@voleatech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).