From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Eric Dumazet <edumazet@google.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
coreteam@netfilter.org, Florian Westphal <fw@strlen.de>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Julian Anastasov <ja@ssi.bg>,
lvs-devel@vger.kernel.org, Matteo Croce <mcroce@redhat.com>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Simon Horman <horms@verge.net.au>
Subject: [PATCH net-next v2 1/4] ipv6: silence compilation warning for non-IPV6 builds
Date: Wed, 3 Feb 2021 15:51:09 +0200 [thread overview]
Message-ID: <20210203135112.4083711-2-leon@kernel.org> (raw)
In-Reply-To: <20210203135112.4083711-1-leon@kernel.org>
From: Leon Romanovsky <leonro@nvidia.com>
The W=1 compilation of allmodconfig generates the following warning:
net/ipv6/icmp.c:448:6: warning: no previous prototype for 'icmp6_send' [-Wmissing-prototypes]
448 | void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
| ^~~~~~~~~~
Fix it by providing function declaration for builds with ipv6 as a module.
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
include/linux/icmpv6.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h
index 1b3371ae8193..452d8978ffc7 100644
--- a/include/linux/icmpv6.h
+++ b/include/linux/icmpv6.h
@@ -16,9 +16,9 @@ static inline struct icmp6hdr *icmp6_hdr(const struct sk_buff *skb)
typedef void ip6_icmp_send_t(struct sk_buff *skb, u8 type, u8 code, __u32 info,
const struct in6_addr *force_saddr);
-#if IS_BUILTIN(CONFIG_IPV6)
void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
const struct in6_addr *force_saddr);
+#if IS_BUILTIN(CONFIG_IPV6)
static inline void icmpv6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info)
{
icmp6_send(skb, type, code, info, NULL);
--
2.29.2
next prev parent reply other threads:[~2021-02-03 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 13:51 [PATCH net-next v2 0/4] Fix W=1 compilation warnings in net/* folder Leon Romanovsky
2021-02-03 13:51 ` Leon Romanovsky [this message]
2021-02-03 13:51 ` [PATCH net-next v2 2/4] ipv6: move udp declarations to net/udp.h Leon Romanovsky
2021-02-03 13:51 ` [PATCH net-next v2 3/4] net/core: move gro function declarations to separate header Leon Romanovsky
2021-02-03 13:51 ` [PATCH net-next v2 4/4] netfilter: move handlers to net/ip_vs.h Leon Romanovsky
2021-02-05 5:07 ` [PATCH net-next v2 0/4] Fix W=1 compilation warnings in net/* folder Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203135112.4083711-2-leon@kernel.org \
--to=leon@kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=lvs-devel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).