From: Florian Westphal <fw@strlen.de>
To: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: x_tables: Use correct memory barriers.
Date: Thu, 4 Mar 2021 08:46:48 +0100 [thread overview]
Message-ID: <20210304074648.GJ17911@breakpoint.cc> (raw)
In-Reply-To: <20210304013116.8420-4-mark.tomlinson@alliedtelesis.co.nz>
Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz> wrote:
> When a new table value was assigned, it was followed by a write memory
> barrier. This ensured that all writes before this point would complete
> before any writes after this point. However, to determine whether the
> rules are unused, the sequence counter is read. To ensure that all
> writes have been done before these reads, a full memory barrier is
> needed, not just a write memory barrier. The same argument applies when
> incrementing the counter, before the rules are read.
>
> Changing to using smp_mb() instead of smp_wmb() fixes the kernel panic
> reported in cc00bcaa5899,
Can you reproduce the crashes without this change?
> while still maintaining the same speed of replacing tables.
How much of an impact is the MB change on the packet path?
Please also CC authors of the patches you want reverted when reposting.
next prev parent reply other threads:[~2021-03-04 7:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 1:31 [PATCH 0/3] Don't use RCU for x_tables synchronization Mark Tomlinson
2021-03-04 1:31 ` [PATCH 1/3] Revert "netfilter: x_tables: Update remaining dereference to RCU" Mark Tomlinson
2021-03-04 7:43 ` Florian Westphal
2021-03-04 1:31 ` [PATCH 2/3] Revert "netfilter: x_tables: Switch synchronization " Mark Tomlinson
2021-03-04 7:44 ` Florian Westphal
2021-03-04 1:31 ` [PATCH 3/3] netfilter: x_tables: Use correct memory barriers Mark Tomlinson
2021-03-04 7:46 ` Florian Westphal [this message]
2021-03-05 3:30 ` Mark Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304074648.GJ17911@breakpoint.cc \
--to=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.tomlinson@alliedtelesis.co.nz \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).