From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack-tools] conntrackd: set default hashtable buckets and max entries if not specified
Date: Tue, 9 Mar 2021 11:05:43 +0100 [thread overview]
Message-ID: <20210309100543.GA30640@salvia> (raw)
In-Reply-To: <c85d5bbc-0f47-1f78-7eb5-8468bf56e78f@netfilter.org>
On Tue, Mar 09, 2021 at 10:51:20AM +0100, Arturo Borrero Gonzalez wrote:
> On 3/8/21 4:32 PM, Pablo Neira Ayuso wrote:
> > Fall back to 65536 buckets and 262144 entries.
> >
> > It would be probably good to add code to autoadjust by reading
> > /proc/sys/net/netfilter/nf_conntrack_buckets and
> > /proc/sys/net/nf_conntrack_max.
> >
> > Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1491
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > ---
> > src/read_config_yy.y | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
>
> Thanks for the patch!
>
> Would it make sense to have all this logic in evaluate() in src/run.c?
I think so. A patch to move it there would be fine.
I suspect there might more missing sanity checks in the configuration
file parser (options that are not set to default value, like hashsize
and hashlimit).
prev parent reply other threads:[~2021-03-09 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 15:32 [PATCH conntrack-tools] conntrackd: set default hashtable buckets and max entries if not specified Pablo Neira Ayuso
2021-03-09 9:51 ` Arturo Borrero Gonzalez
2021-03-09 10:05 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309100543.GA30640@salvia \
--to=pablo@netfilter.org \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).