From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [libnftnl PATCH 00/10] Kill non-default output leftovers
Date: Tue, 9 Mar 2021 16:45:06 +0100 [thread overview]
Message-ID: <20210309154516.4987-1-phil@nwl.cc> (raw)
Any other (debug) output format types than the default have been removed
for a while now. Assuming no new ones will be introduced anymore,
eliminate some of the still existing infrastructure accommodating for
them and a few obvious leftovers.
While working on the above, I identified some real issues (albeit only
triggered with very small output buffers. They come in patches 1-4,
separated by fixing commit.
Instead of proper testing these changes, I went with 'make check' and
running nftables' tests/py testsuite which actually compares the
libnftnl output against records.
Phil Sutter (10):
expr: Fix snprintf buffer length updates
obj/ct_expect: Fix snprintf buffer length updates
obj/ct_timeout: Fix snprintf buffer length updates
object: Fix for wrong parameter passed to snprintf callback
expr: Check output type once and for all
expr/data_reg: Drop output_format parameter
obj: Drop type parameter from snprintf callback
Drop pointless local variable in snprintf callbacks
Get rid of single option switch statements
ruleset: Eliminate tag and separator helpers
include/data_reg.h | 3 +-
include/expr_ops.h | 2 +-
include/obj.h | 2 +-
src/chain.c | 20 ++--
src/expr.c | 10 +-
src/expr/bitwise.c | 32 ++-----
src/expr/byteorder.c | 22 +----
src/expr/cmp.c | 24 +----
src/expr/connlimit.c | 20 +---
src/expr/counter.c | 20 +---
src/expr/ct.c | 23 +----
src/expr/data_reg.c | 35 ++-----
src/expr/dup.c | 25 +----
src/expr/dynset.c | 21 +----
src/expr/exthdr.c | 20 +---
src/expr/fib.c | 21 +----
src/expr/flow_offload.c | 20 +---
src/expr/fwd.c | 21 +----
src/expr/hash.c | 21 +----
src/expr/immediate.c | 28 ++----
src/expr/limit.c | 20 +---
src/expr/log.c | 22 +----
src/expr/lookup.c | 21 +----
src/expr/masq.c | 20 +---
src/expr/match.c | 13 +--
src/expr/meta.c | 19 +---
src/expr/nat.c | 21 +----
src/expr/numgen.c | 21 +----
src/expr/objref.c | 20 +---
src/expr/osf.c | 22 +----
src/expr/payload.c | 32 +++----
src/expr/queue.c | 34 ++-----
src/expr/quota.c | 20 +---
src/expr/range.c | 24 +----
src/expr/redir.c | 28 ++----
src/expr/reject.c | 20 +---
src/expr/rt.c | 19 +---
src/expr/socket.c | 19 +---
src/expr/synproxy.c | 22 +----
src/expr/target.c | 13 +--
src/expr/tproxy.c | 19 +---
src/expr/tunnel.c | 19 +---
src/expr/xfrm.c | 21 +----
src/flowtable.c | 21 ++---
src/gen.c | 14 +--
src/obj/counter.c | 22 +----
src/obj/ct_expect.c | 39 +++-----
src/obj/ct_helper.c | 22 +----
src/obj/ct_timeout.c | 35 ++-----
src/obj/limit.c | 23 +----
src/obj/quota.c | 23 +----
src/obj/secmark.c | 23 +----
src/obj/synproxy.c | 22 +----
src/obj/tunnel.c | 21 +----
src/object.c | 28 ++----
src/rule.c | 22 ++---
src/ruleset.c | 200 +++++++++++++++-------------------------
src/set.c | 26 ++----
src/set_elem.c | 27 ++----
src/table.c | 16 +---
60 files changed, 337 insertions(+), 1126 deletions(-)
--
2.30.1
next reply other threads:[~2021-03-09 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 15:45 Phil Sutter [this message]
2021-03-09 15:45 ` [libnftnl PATCH 01/10] expr: Fix snprintf buffer length updates Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 02/10] obj/ct_expect: " Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 03/10] obj/ct_timeout: " Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 04/10] object: Fix for wrong parameter passed to snprintf callback Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 05/10] expr: Check output type once and for all Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 06/10] expr/data_reg: Drop output_format parameter Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 07/10] obj: Drop type parameter from snprintf callback Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 08/10] Drop pointless local variable in snprintf callbacks Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 09/10] Get rid of single option switch statements Phil Sutter
2021-03-09 15:45 ` [libnftnl PATCH 10/10] ruleset: Eliminate tag and separator helpers Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309154516.4987-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).