From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: ctnetlink: fix dump of the expect mask attribute
Date: Mon, 15 Mar 2021 18:43:45 +0100 [thread overview]
Message-ID: <20210315174345.GA25442@salvia> (raw)
In-Reply-To: <20210315103109.12004-1-fw@strlen.de>
On Mon, Mar 15, 2021 at 11:31:09AM +0100, Florian Westphal wrote:
> Before this change, the mask is never included in the netlink message, so
> "conntrack -E expect" always prints 0.0.0.0.
>
> In older kernels the l3num callback struct was passed as argument, based
> on tuple->src.l3num. After the l3num indirection got removed, the call
> chain is based on m.src.l3num, but this value is 0xffff.
>
> Init l3num to the correct value.
Applied, thanks.
prev parent reply other threads:[~2021-03-15 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 10:31 [PATCH nf] netfilter: ctnetlink: fix dump of the expect mask attribute Florian Westphal
2021-03-15 17:43 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315174345.GA25442@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).