From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Oz Shlomo <ozsh@nvidia.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Saeed Mahameed <saeedm@nvidia.com>,
Paul Blakey <paulb@nvidia.com>
Subject: Re: [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues
Date: Thu, 18 Mar 2021 00:36:30 +0100 [thread overview]
Message-ID: <20210317233630.GA2480@salvia> (raw)
In-Reply-To: <20210303125953.11911-1-ozsh@nvidia.com>
On Wed, Mar 03, 2021 at 02:59:53PM +0200, Oz Shlomo wrote:
> Currently the flow table offload replace, destroy and stats work items are
> executed on a single workqueue. As such, DESTROY and STATS commands may
> be backloged after a burst of REPLACE work items. This scenario can bloat
> up memory and may cause active connections to age.
>
> Instatiate add, del and stats workqueues to avoid backlogs of non-dependent
> actions. Provide sysfs control over the workqueue attributes, allowing
> userspace applications to control the workqueue cpumask.
I'm going to apply this to nf-next, it should be possible to revisit
this problem incrementally.
Applied, thanks for your patience.
prev parent reply other threads:[~2021-03-17 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 12:59 [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues Oz Shlomo
2021-03-03 16:11 ` Pablo Neira Ayuso
2021-03-22 18:09 ` Marcelo Ricardo Leitner
2021-03-24 1:38 ` Pablo Neira Ayuso
2021-03-24 11:24 ` Oz Shlomo
2021-03-24 21:20 ` Marcelo Ricardo Leitner
2021-03-25 8:46 ` Oz Shlomo
2021-03-26 13:51 ` Marcelo Ricardo Leitner
2021-03-17 23:36 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317233630.GA2480@salvia \
--to=pablo@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=paulb@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).