From: Florian Westphal <fw@strlen.de>
To: Luuk Paulussen <Luuk.Paulussen@alliedtelesis.co.nz>
Cc: "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>
Subject: Re: Bug when updating ICMP flows using conntrack tools
Date: Thu, 18 Mar 2021 14:01:38 +0100 [thread overview]
Message-ID: <20210318130138.GC22603@breakpoint.cc> (raw)
In-Reply-To: <1616049521015.25557@alliedtelesis.co.nz>
Luuk Paulussen <Luuk.Paulussen@alliedtelesis.co.nz> wrote:
> However, in libnetfilter-conntrack the way that the message is built has been changed, and in nfct_nlmsg_build, the check about whether to build the REPL tuple has been extended to include
> test_bit(ATTR_ICMP_TYPE, ct->head.set) ||
> test_bit(ATTR_ICMP_CODE, ct->head.set) ||
> test_bit(ATTR_ICMP_ID, ct->head.set)
That looks like a bug, those checks should only be done for ORIG.
next prev parent reply other threads:[~2021-03-18 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 6:38 Bug when updating ICMP flows using conntrack tools Luuk Paulussen
2021-03-18 13:01 ` Florian Westphal [this message]
2021-03-18 19:59 ` [PATCH libnetfilter_conntrack] conntrack: Don't use ICMP attrs in decision to build repl tuple Luuk Paulussen
2021-03-19 14:00 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318130138.GC22603@breakpoint.cc \
--to=fw@strlen.de \
--cc=Luuk.Paulussen@alliedtelesis.co.nz \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).