From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D20C433DB for ; Wed, 24 Mar 2021 11:23:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1393061A06 for ; Wed, 24 Mar 2021 11:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232548AbhCXLWw (ORCPT ); Wed, 24 Mar 2021 07:22:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232369AbhCXLWg (ORCPT ); Wed, 24 Mar 2021 07:22:36 -0400 Received: from mail.netfilter.org (mail.netfilter.org [IPv6:2001:4b98:dc0:41:216:3eff:fe8c:2bda]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8A8CBC061763 for ; Wed, 24 Mar 2021 04:22:36 -0700 (PDT) Received: from us.es (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 26CFE62BDE; Wed, 24 Mar 2021 12:22:25 +0100 (CET) Date: Wed, 24 Mar 2021 12:22:30 +0100 From: Pablo Neira Ayuso To: Mikhail Sennikovsky Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH v3 1/8] conntrack: reset optind in do_parse Message-ID: <20210324112230.GA7694@salvia> References: <20210129212452.45352-1-mikhail.sennikovskii@cloud.ionos.com> <20210129212452.45352-2-mikhail.sennikovskii@cloud.ionos.com> <20210315171819.GA25083@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Mar 17, 2021 at 07:31:18PM +0100, Mikhail Sennikovsky wrote: > Hi Pablo, > > Sure, so taking into account your comments to 3/8 and 4/8 I collapse > 1-5/8 in a single commit, correct? Yes please. My understanding is that they belong to the same logical changes, that is, add batch support. So this new "batch support" for conntrack is all new code that can be added at once IMO. Thanks.