From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8069C433DB for ; Tue, 30 Mar 2021 17:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6199661864 for ; Tue, 30 Mar 2021 17:40:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232259AbhC3Rj2 (ORCPT ); Tue, 30 Mar 2021 13:39:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231650AbhC3RjD (ORCPT ); Tue, 30 Mar 2021 13:39:03 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B40EEC061574 for ; Tue, 30 Mar 2021 10:39:02 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lRIKS-0005xp-T3; Tue, 30 Mar 2021 19:39:00 +0200 Date: Tue, 30 Mar 2021 19:39:00 +0200 From: Florian Westphal To: Alexander Mikhalitsyn Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org, fw@strlen.de Subject: Re: [iptables PATCH v2 2/2] extensions: libxt_conntrack: print xlate status as set Message-ID: <20210330173900.GB17285@breakpoint.cc> References: <20210330141524.747259-1-alexander.mikhalitsyn@virtuozzo.com> <20210330141524.747259-2-alexander.mikhalitsyn@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330141524.747259-2-alexander.mikhalitsyn@virtuozzo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Alexander Mikhalitsyn wrote: > status_xlate_print function prints statusmask > without { ... } around. But if ctstatus condition is > negative, then we have to use { ... } after "!=" operator in nft Not really. > Reproducer: > $ iptables -A INPUT -d 127.0.0.1/32 -p tcp -m conntrack ! --ctstatus expected,assured -j DROP > $ nft list ruleset > ... > meta l4proto tcp ip daddr 127.0.0.1 ct status != expected,assured counter packets 0 bytes 0 drop > ... Yes, nft can't parse that. But ct status { expect, assured } is NOT The same as 'ct status expect,assured'. expect, assured etc. are all bit flags, so when negating this needs to be something like 'ct status & (expected|assured) == 0'. (ct is neither expected nor assured).