From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E016BC433DB for ; Tue, 30 Mar 2021 22:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A60C4619C2 for ; Tue, 30 Mar 2021 22:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232975AbhC3WvE (ORCPT ); Tue, 30 Mar 2021 18:51:04 -0400 Received: from mail.netfilter.org ([217.70.188.207]:46462 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232966AbhC3Wu6 (ORCPT ); Tue, 30 Mar 2021 18:50:58 -0400 Received: from us.es (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 4AAE163E4D; Wed, 31 Mar 2021 00:50:43 +0200 (CEST) Date: Wed, 31 Mar 2021 00:50:55 +0200 From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, phil@nwl.cc Subject: Re: [PATCH 0/8] netfilter: merge nf_log_proto modules Message-ID: <20210330225055.GA14374@salvia> References: <20210325172512.17729-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210325172512.17729-1-fw@strlen.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Mar 25, 2021 at 06:25:04PM +0100, Florian Westphal wrote: > Netfilter has multiple log modules: > nf_log_arp > nf_log_bridge > nf_log_ipv4 > nf_log_ipv6 > nf_log_netdev > nfnetlink_log > nf_log_common > > With the exception of nfnetlink_log (packet is sent to userspace for > dissection/logging) all of them log to the kernel ringbuffer. > > This series merges all modules except nfnetlink_log into a single > module, nf_log_syslog. > > After the series, only two log modules remain: > nfnetlink_log and nf_log_syslog. The latter provides the same > functionality as the old per-af log modules. > > Last patch allows to move log backend module load > to nft_log to avoid a deadlock that can occur when request_module() > is called with the nft transaction mutex held. Series applied to nf-next, thanks.