From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37CCDC43603 for ; Sat, 3 Apr 2021 11:32:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0395761151 for ; Sat, 3 Apr 2021 11:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236515AbhDCLcE (ORCPT ); Sat, 3 Apr 2021 07:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236484AbhDCLcE (ORCPT ); Sat, 3 Apr 2021 07:32:04 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4451C0613E6 for ; Sat, 3 Apr 2021 04:32:01 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lSeVT-0004Ds-RD; Sat, 03 Apr 2021 13:31:59 +0200 Date: Sat, 3 Apr 2021 13:31:59 +0200 From: Florian Westphal To: Phil Sutter , Florian Westphal , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] nft: Increase BATCH_PAGE_SIZE to support huge rulesets Message-ID: <20210403113159.GM13699@breakpoint.cc> References: <20210401145307.29927-1-phil@nwl.cc> <20210402053810.GI13699@breakpoint.cc> <20210403084940.GA3158@orbyte.nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210403084940.GA3158@orbyte.nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > > Isn't that library code? At the very least this should use > > nft_print(). > > Good point, but for the upcoming identical change to nftables! ;) > There I'm still undecided about the best way to handle it. For iptables, > I guess this minimal error reporting to stderr for a case that shouldn't > happen is fine. ACK? Oh right.