From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Paul Moore <paul@paul-moore.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Richard Guy Briggs <rgb@redhat.com>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] netfilter: nftables: fix a warning message in nf_tables_commit_audit_collect()
Date: Sat, 3 Apr 2021 20:18:50 +0200 [thread overview]
Message-ID: <20210403181850.GA4976@salvia> (raw)
In-Reply-To: <CAHC9VhQ4D25kvzjXyvk8eJFXCOAaxuzUkSyNTePSrBHONxXZwQ@mail.gmail.com>
On Fri, Apr 02, 2021 at 11:57:20AM -0400, Paul Moore wrote:
> On Fri, Apr 2, 2021 at 7:46 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The first argument of a WARN_ONCE() is a condition. This WARN_ONCE()
> > will only print the table name, and is potentially problematic if the
> > table name has a %s in it.
> >
> > Fixes: bb4052e57b5b ("audit: log nftables configuration change events once per table")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > net/netfilter/nf_tables_api.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks Dan.
>
> Reviewed-by: Paul Moore <paul@paul-moore.com>
Applied, thanks.
next prev parent reply other threads:[~2021-04-03 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 11:45 [PATCH] netfilter: nftables: fix a warning message in nf_tables_commit_audit_collect() Dan Carpenter
2021-04-02 15:57 ` Paul Moore
2021-04-03 18:18 ` Pablo Neira Ayuso [this message]
2021-04-15 20:23 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210403181850.GA4976@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=dan.carpenter@oracle.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).