From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Firo Yang <firo.yang@suse.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] ebtables: processing '--concurrent' beofore other arguments
Date: Sat, 3 Apr 2021 20:22:04 +0200 [thread overview]
Message-ID: <20210403182204.GA5182@salvia> (raw)
In-Reply-To: <20210403181517.GA4624@salvia>
On Sat, Apr 03, 2021 at 08:15:17PM +0200, Pablo Neira Ayuso wrote:
> Hi,
>
> On Thu, Apr 01, 2021 at 12:07:40PM +0800, Firo Yang wrote:
> > Our customer reported a following issue:
> > If '--concurrent' was passed to ebtables command behind other arguments,
> > '--concurrent' will not take effect sometimes; for a simple example,
> > ebtables -L --concurrent. This is becuase the handling of '--concurrent'
> > is implemented in a passing-order-dependent way.
> >
> > So we can fix this problem by processing it before other arguments.
>
> Would you instead make a patch to spew an error if --concurrent is the
> first argument?
Wrong wording:
Would you instead make a patch to spew an error if --concurrent is
_not_ the first argument?
> --concurrent has never worked unless you place it in first place
> anyway.
next prev parent reply other threads:[~2021-04-03 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 4:07 [PATCH 0/2] Two fixes related to '--concurrent' Firo Yang
2021-04-01 4:07 ` [PATCH 1/2] ebtables: processing '--concurrent' beofore other arguments Firo Yang
2021-04-03 18:15 ` Pablo Neira Ayuso
2021-04-03 18:22 ` Pablo Neira Ayuso [this message]
2021-04-06 2:57 ` Firo Yang
2021-04-06 9:50 ` Pablo Neira Ayuso
[not found] ` <6cc20464d5814fe899d7fb1e21d5488c@DB8PR04MB5881.eurprd04.prod.outlook.com>
2021-04-06 7:59 ` Simon Lees
2021-04-06 9:52 ` Pablo Neira Ayuso
[not found] ` <64466cd69b054f5d803722dfbcf8c4be@DB8PR04MB5881.eurprd04.prod.outlook.com>
2021-04-06 11:21 ` Simon Lees
2021-04-06 11:31 ` Pablo Neira Ayuso
2021-04-06 11:56 ` Firo Yang
2021-04-01 4:07 ` [PATCH 2/2] libebtc: Fix an issue that '--concurrent' doesn't work with NFS Firo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210403182204.GA5182@salvia \
--to=pablo@netfilter.org \
--cc=firo.yang@suse.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).