From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Luigi Rizzo <lrizzo@google.com>,
syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH net] netfilter: nft_limit: avoid possible divide error in nft_limit_init
Date: Sat, 10 Apr 2021 21:15:25 +0200 [thread overview]
Message-ID: <20210410191525.GA17033@salvia> (raw)
In-Reply-To: <20210409154939.43020-1-eric.dumazet@gmail.com>
On Fri, Apr 09, 2021 at 08:49:39AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> div_u64() divides u64 by u32.
>
> nft_limit_init() wants to divide u64 by u64, use the appropriate
> math function (div64_u64)
>
> divide error: 0000 [#1] PREEMPT SMP KASAN
> CPU: 1 PID: 8390 Comm: syz-executor188 Not tainted 5.12.0-rc4-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:div_u64_rem include/linux/math64.h:28 [inline]
> RIP: 0010:div_u64 include/linux/math64.h:127 [inline]
> RIP: 0010:nft_limit_init+0x2a2/0x5e0 net/netfilter/nft_limit.c:85
Applied to nf.git, thanks
prev parent reply other threads:[~2021-04-10 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 15:49 [PATCH net] netfilter: nft_limit: avoid possible divide error in nft_limit_init Eric Dumazet
2021-04-10 19:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210410191525.GA17033@salvia \
--to=pablo@netfilter.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=lrizzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).