From: Florian Westphal <fw@strlen.de>
To: Ali Abdallah <ali.abdallah@suse.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] conntrack_tcp: Reset the max ACK flag on SYN in ignore state
Date: Tue, 13 Apr 2021 15:45:17 +0200 [thread overview]
Message-ID: <20210413134517.GC14932@breakpoint.cc> (raw)
In-Reply-To: <20210413122436.aejo4pwaafwrlzsh@Fryzen495>
Ali Abdallah <ali.abdallah@suse.com> wrote:
> Hi,
>
> Please find out the updated patch with the fixed comment.
>
> PS: I'm just wondering if isn't better to just reset the MAXACK_SET on
> both directions once an RST is observed on the tracked connection, what
> do you think?
Mhh, can you share a patch? Your patch clears it when a SYN is
observed, so I am not sure what you mean.
I think the patch is good; we only need to handle the case where we
let a SYN through, and might be out of state.
So, we only need to handle the reply dir, no?
next prev parent reply other threads:[~2021-04-13 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 6:12 [PATCH] conntrack_tcp: Reset the max ACK flag on SYN in ignore state Ali Abdallah
2021-04-08 9:04 ` Florian Westphal
2021-04-13 12:24 ` Ali Abdallah
2021-04-13 13:45 ` Florian Westphal [this message]
2021-04-13 13:58 ` Ali Abdallah
2021-04-20 11:45 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413134517.GC14932@breakpoint.cc \
--to=fw@strlen.de \
--cc=ali.abdallah@suse.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).