Re: [PATCH nf-next] netfilter: disable defrag once its no longer needed

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]

Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-disable-defrag-once-its-no-longer-needed/20210420-221253
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: mips-malta_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ca9d65d5dcd9df977e75304aa896814e60965484
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Florian-Westphal/netfilter-disable-defrag-once-its-no-longer-needed/20210420-221253
        git checkout ca9d65d5dcd9df977e75304aa896814e60965484
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/netfilter/xt_TPROXY.c: In function 'tproxy_tg6_destroy':
>> net/netfilter/xt_TPROXY.c:229:2: error: implicit declaration of function 'nf_defrag_ipv6_disable'; did you mean 'nf_defrag_ipv4_disable'? [-Werror=implicit-function-declaration]
     229 |  nf_defrag_ipv6_disable(par->net);
         |  ^~~~~~~~~~~~~~~~~~~~~~
         |  nf_defrag_ipv4_disable
   At top level:
   net/netfilter/xt_TPROXY.c:227:13: warning: 'tproxy_tg6_destroy' defined but not used [-Wunused-function]
     227 | static void tproxy_tg6_destroy(const struct xt_tgdtor_param *par)
         |             ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +229 net/netfilter/xt_TPROXY.c

   226	
   227	static void tproxy_tg6_destroy(const struct xt_tgdtor_param *par)
   228	{
 > 229		nf_defrag_ipv6_disable(par->net);
   230	}
   231	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20584 bytes --]