From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 nf-next] netfilter: disable defrag once its no longer needed
Date: Mon, 26 Apr 2021 03:24:26 +0200 [thread overview]
Message-ID: <20210426012426.GA30996@salvia> (raw)
In-Reply-To: <20210421074540.18983-1-fw@strlen.de>
On Wed, Apr 21, 2021 at 09:45:40AM +0200, Florian Westphal wrote:
> When I changed defrag hooks to no longer get registered by default I
> intentionally made it so that registration can only be un-done by unloading
> the nf_defrag_ipv4/6 module.
>
> In hindsight this was too conservative; there is no reason to keep defrag
> on while there is no feature dependency anymore.
>
> Moreover, this won't work if user isn't allowed to remove nf_defrag module.
>
> This adds the disable() functions for both ipv4 and ipv6 and calls them
> from conntrack, TPROXY and the xtables socket module.
>
> ipvs isn't converted here, it will behave as before this patch and
> will need module removal.
Applied, thanks.
prev parent reply other threads:[~2021-04-26 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 7:45 [PATCH v2 nf-next] netfilter: disable defrag once its no longer needed Florian Westphal
2021-04-26 1:24 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426012426.GA30996@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).