From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Pallavi Prabhu <rpallaviprabhu@gmail.com>
Cc: kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: netfilter.c: fix missing line after declaration
Date: Thu, 6 May 2021 00:41:21 +0200 [thread overview]
Message-ID: <20210505224121.GA23510@salvia> (raw)
In-Reply-To: <20210505192007.GA12080@pallavi>
Hi Pallavi,
On Thu, May 06, 2021 at 12:50:07AM +0530, Pallavi Prabhu wrote:
> Fixed a missing line after a declaration for proper coding style.
I'd probably suggest to use Coccinelle or similar to make a Netfilter
tree wide patch to add line after a declaration.
Probably there are more spots in the Netfilter codebase that can
benefit from this cleanup.
> Signed-off-by: Pallavi Prabhu <rpallaviprabhu@gmail.com>
> ---
> net/ipv6/netfilter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
> index ab9a279dd6d4..7b1671f48593 100644
> --- a/net/ipv6/netfilter.c
> +++ b/net/ipv6/netfilter.c
> @@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb,
>
> if (entry->state.hook == NF_INET_LOCAL_OUT) {
> const struct ipv6hdr *iph = ipv6_hdr(skb);
> +
> if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) ||
> !ipv6_addr_equal(&iph->saddr, &rt_info->saddr) ||
> skb->mark != rt_info->mark)
> --
> 2.25.1
>
prev parent reply other threads:[~2021-05-05 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 19:20 [PATCH] ipv6: netfilter.c: fix missing line after declaration Pallavi Prabhu
2021-05-05 22:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505224121.GA23510@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rpallaviprabhu@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).