* [PATCH nftables] evaluate: don't crash on set definition with incorrect datatype
@ 2021-05-10 16:55 Pablo Neira Ayuso
0 siblings, 0 replies; only message in thread
From: Pablo Neira Ayuso @ 2021-05-10 16:55 UTC (permalink / raw)
To: netfilter-devel
Cache updates have resurrected the bug described in 5afa5a164ff1
("evaluate: check for NULL datatype in rhs in lookup expr").
This is triggered by testcases/cache/0008_delete_by_handle_0.
Fixes: df48e56e987f ("cache: add hashtable cache for sets")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/evaluate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index e91d5236564e..75983b3c7a6a 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -262,7 +262,7 @@ static int expr_evaluate_symbol(struct eval_ctx *ctx, struct expr **expr)
return table_not_found(ctx);
set = set_cache_find(table, (*expr)->identifier);
- if (set == NULL)
+ if (set == NULL || !set->key)
return set_not_found(ctx, &(*expr)->location,
(*expr)->identifier);
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-10 16:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-10 16:55 [PATCH nftables] evaluate: don't crash on set definition with incorrect datatype Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).