* [nft PATCH] expr_postprocess: Avoid an unintended fall through
@ 2021-05-20 13:14 Phil Sutter
0 siblings, 0 replies; only message in thread
From: Phil Sutter @ 2021-05-20 13:14 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
Parsing a range expression, the switch case fell through to prefix
expression case, thereby recursing once more for expr->left. This seems
not to have caused harm, but is certainly not intended.
Fixes: ee4391d0ac1e7 ("nat: transform range to prefix expression when possible")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
src/netlink_delinearize.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c
index 75869d330ef4d..a71d06d7fe12f 100644
--- a/src/netlink_delinearize.c
+++ b/src/netlink_delinearize.c
@@ -2450,6 +2450,7 @@ static void expr_postprocess(struct rule_pp_ctx *ctx, struct expr **exprp)
case EXPR_RANGE:
expr_postprocess(ctx, &expr->left);
expr_postprocess(ctx, &expr->right);
+ break;
case EXPR_PREFIX:
expr_postprocess(ctx, &expr->prefix);
break;
--
2.31.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-20 13:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-20 13:14 [nft PATCH] expr_postprocess: Avoid an unintended fall through Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).