From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 4/4] netfilter: nf_tables: include table and chain name when dumping hooks
Date: Sun, 23 May 2021 23:26:46 +0200 [thread overview]
Message-ID: <20210523212646.GC31080@breakpoint.cc> (raw)
In-Reply-To: <20210523210320.GA14705@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, May 23, 2021 at 08:54:31PM +0200, Florian Westphal wrote:
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > On Fri, May 21, 2021 at 01:39:22PM +0200, Florian Westphal wrote:
> > > > * @NFTA_HOOK_FUNCTION_NAME: hook function name (NLA_STRING)
> > > > * @NFTA_HOOK_MODULE_NAME: kernel module that registered this hook (NLA_STRING)
> > > > + * @NFTA_HOOK_NFT_CHAIN_INFO: nft chain and table name (NLA_NESTED)
> > >
> > > Probably NFTA_HOOK_CHAIN_INFO ?
> >
> > I added _NFT_ to avoid ambiguity in case this would be extended
> > to add xt-legacy chain info. I can drop the _NFT_, let me know.
>
> It's a NLA_NESTED, you might add a _TYPE field inside the nest to
> describe what type of chain info is stored there, maybe?
It uses enum nft_chain_attributes, it somehow feels wrong to add a
'type' field for that.
I could add a new enum if you prefer.
At this point I don't think adding xt specific info is useful
because the chain function name already tell if its mangle, raw etc.
next prev parent reply other threads:[~2021-05-23 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 11:39 [PATCH nf-next 0/4] netfilter: add hook dump feature Florian Westphal
2021-05-21 11:39 ` [PATCH nf-next 1/4] netfilter: nf_tables: allow to dump all registered base hooks Florian Westphal
2021-05-22 22:49 ` kernel test robot
2021-05-21 11:39 ` [PATCH nf-next 2/4] netfilter: nf_tables: include function and module name in hook dumps Florian Westphal
2021-05-21 11:39 ` [PATCH nf-next 3/4] netfilter: annotate nf_tables base hook ops Florian Westphal
2021-05-21 11:39 ` [PATCH nf-next 4/4] netfilter: nf_tables: include table and chain name when dumping hooks Florian Westphal
2021-05-23 8:52 ` Pablo Neira Ayuso
2021-05-23 18:54 ` Florian Westphal
2021-05-23 21:03 ` Pablo Neira Ayuso
2021-05-23 21:26 ` Florian Westphal [this message]
2021-05-23 21:36 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2021-05-25 20:51 [PATCH nf-next v2 0/4] netfilter: add hook dump feature Florian Westphal
2021-05-25 20:51 ` [PATCH nf-next 4/4] netfilter: nf_tables: include table and chain name when dumping hooks Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523212646.GC31080@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).