netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: kernel test robot <lkp@intel.com>
Cc: Florian Westphal <fw@strlen.de>,
	kbuild-all@lists.01.org, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [nf-next:master 4/14] net/netfilter/nft_set_pipapo.c:412:6: error: static declaration of 'nft_pipapo_lookup' follows non-static declaration
Date: Fri, 28 May 2021 23:30:01 +0200	[thread overview]
Message-ID: <20210528213001.GA10732@breakpoint.cc> (raw)
In-Reply-To: <202105290441.yixDLttm-lkp@intel.com>

kernel test robot <lkp@intel.com> wrote:
> All errors (new ones prefixed by >>):
> 
> >> net/netfilter/nft_set_pipapo.c:412:6: error: static declaration of 'nft_pipapo_lookup' follows non-static declaration
>      412 | bool nft_pipapo_lookup(const struct net *net, const struct nft_set *set,
>          |      ^~~~~~~~~~~~~~~~~
>    In file included from net/netfilter/nft_set_pipapo.c:343:
>    net/netfilter/nft_set_pipapo.h:181:6: note: previous declaration of 'nft_pipapo_lookup' was here
>      181 | bool nft_pipapo_lookup(const struct net *net, const struct nft_set *set,
>          |      ^~~~~~~~~~~~~~~~~
> 
> 
> vim +/nft_pipapo_lookup +412 net/netfilter/nft_set_pipapo.c
> 
> 3c4287f62044a9 Stefano Brivio   2020-01-22  399  
> 3c4287f62044a9 Stefano Brivio   2020-01-22  400  /**
> 3c4287f62044a9 Stefano Brivio   2020-01-22  401   * nft_pipapo_lookup() - Lookup function
> 3c4287f62044a9 Stefano Brivio   2020-01-22  402   * @net:	Network namespace
> 3c4287f62044a9 Stefano Brivio   2020-01-22  403   * @set:	nftables API set representation
> 3db86c397f608b Andrew Lunn      2020-07-13  404   * @key:	nftables API element representation containing key data
> 3c4287f62044a9 Stefano Brivio   2020-01-22  405   * @ext:	nftables API extension pointer, filled with matching reference
> 3c4287f62044a9 Stefano Brivio   2020-01-22  406   *
> 3c4287f62044a9 Stefano Brivio   2020-01-22  407   * For more details, see DOC: Theory of Operation.
> 3c4287f62044a9 Stefano Brivio   2020-01-22  408   *
> 3c4287f62044a9 Stefano Brivio   2020-01-22  409   * Return: true on match, false otherwise.
> 3c4287f62044a9 Stefano Brivio   2020-01-22  410   */
> a890630241c76a Florian Westphal 2021-05-13  411  INDIRECT_CALLABLE_SCOPE

This line needs to be dropped after the nf merge.

  reply	other threads:[~2021-05-28 21:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28 20:54 [nf-next:master 4/14] net/netfilter/nft_set_pipapo.c:412:6: error: static declaration of 'nft_pipapo_lookup' follows non-static declaration kernel test robot
2021-05-28 21:30 ` Florian Westphal [this message]
2021-05-28 22:52   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210528213001.GA10732@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=coreteam@netfilter.org \
    --cc=kbuild-all@lists.01.org \
    --cc=lkp@intel.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).