From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>, kernel test robot <lkp@intel.com>
Subject: [PATCH nf-next] netfilter: nft_compat: fix bridge family target evaluation
Date: Sat, 29 May 2021 18:50:25 +0200 [thread overview]
Message-ID: <20210529165025.146435-1-fw@strlen.de> (raw)
This always evals to true, so all packets get dropped in the ebtables
compat layer. ip(6)tables is fine.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 6d6dbfe7fe1e6e1 ("netfilter: nf_tables: remove xt_action_param from nft_pktinfo")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
Pablo, feel free to squash if you prefer that.
net/netfilter/nft_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_compat.c b/net/netfilter/nft_compat.c
index 936e244f5aba..3144a9ad2f6a 100644
--- a/net/netfilter/nft_compat.c
+++ b/net/netfilter/nft_compat.c
@@ -110,7 +110,7 @@ static void nft_target_eval_bridge(const struct nft_expr *expr,
ret = target->target(skb, &xt);
- if (&xt.hotdrop)
+ if (xt.hotdrop)
ret = NF_DROP;
switch (ret) {
--
2.31.1
next reply other threads:[~2021-05-29 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 16:50 Florian Westphal [this message]
2021-05-29 20:16 ` [PATCH nf-next] netfilter: nft_compat: fix bridge family target evaluation Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210529165025.146435-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=lkp@intel.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).