From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n
Date: Tue, 8 Jun 2021 18:03:25 +0200 [thread overview]
Message-ID: <20210608160325.GA1531@salvia> (raw)
In-Reply-To: <20210608155326.GH20020@breakpoint.cc>
On Tue, Jun 08, 2021 at 05:53:26PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Maybe from Kconfig, select CONFIG_NF_TABLES from NFNETLINK_HOOK to
> > reduce ifdef pollution?
>
> Why? It doesn't depend on nftables?
From kernelside, yes. But you have to compile userspace nftables to
use this infra, unless there is separated tooling, userspace library
or you code your own netlink userspace code.
Adding the "depends on" might also help signal distros that this
subsystem is useful to be turned on.
The #ifdef is perfectly fine to fix the kbuild robot issue, I was just
thinking if it is probably better a different path when looking at the
whole picture.
next prev parent reply other threads:[~2021-06-08 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202106082146.9TmnLWJk-lkp@intel.com>
2021-06-08 14:42 ` [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n Florian Westphal
2021-06-08 15:46 ` Pablo Neira Ayuso
2021-06-08 15:53 ` Florian Westphal
2021-06-08 16:03 ` Pablo Neira Ayuso [this message]
2021-06-08 20:11 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608160325.GA1531@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=lkp@intel.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).