From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
coverity-bot <keescook+coverity-bot@chromium.org>
Subject: Re: [PATCH nf-next] netfilter: move nf_tables base hook annotation to init helper
Date: Wed, 9 Jun 2021 21:35:17 +0200 [thread overview]
Message-ID: <20210609193517.GA4711@salvia> (raw)
In-Reply-To: <20210608210607.13325-1-fw@strlen.de>
On Tue, Jun 08, 2021 at 11:06:07PM +0200, Florian Westphal wrote:
> coverity scanner says:
> 2187 if (nft_is_base_chain(chain)) {
> vvv CID 1505166: Memory - corruptions (UNINIT)
> vvv Using uninitialized value "basechain".
> 2188 basechain->ops.hook_ops_type = NF_HOOK_OP_NF_TABLES;
>
> ... I don't see how nft_is_base_chain() can evaluate to true
> while basechain pointer is garbage.
>
> However, it seems better to place the NF_HOOK_OP_NF_TABLES annotation
> in nft_basechain_hook_init() instead.
Applied, thanks.
prev parent reply other threads:[~2021-06-09 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 21:06 [PATCH nf-next] netfilter: move nf_tables base hook annotation to init helper Florian Westphal
2021-06-09 19:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609193517.GA4711@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=keescook+coverity-bot@chromium.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).