From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] evaluate: restore interval + concatenation in anonymous set
Date: Mon, 14 Jun 2021 13:34:03 +0200 [thread overview]
Message-ID: <20210614113403.GP22614@orbyte.nwl.cc> (raw)
In-Reply-To: <20210611171538.14049-1-pablo@netfilter.org>
Hi Pablo,
On Fri, Jun 11, 2021 at 07:15:38PM +0200, Pablo Neira Ayuso wrote:
> Perform the table and set lookup only for non-anonymous sets, where the
> incremental cache update is required.
>
> The problem fixed by 7aa08d45031e ("evaluate: Perform set evaluation on
> implicitly declared (anonymous) sets") resurrected after the cache
> rework.
>
> # nft add rule x y tcp sport . tcp dport vmap { ssh . 0-65535 : accept, 0-65535 . ssh : accept }
> BUG: invalid range expression type concat
> nft: expression.c:1422: range_expr_value_low: Assertion `0' failed.
> Abort
>
> Add a test case to make sure this does not happen again.
>
> Fixes: 5ec5c706d993 ("cache: add hashtable cache for table")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This triggers a warning:
evaluate.c: In function 'set_evaluate':
evaluate.c:3870:13: warning: 'table' may be used uninitialized in this function [-Wmaybe-uninitialized]
3870 | if (set_cache_find(table, set->handle.set.name) == NULL)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Cheers, Phil
next prev parent reply other threads:[~2021-06-14 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 17:15 [PATCH nft 2/2] evaluate: restore interval + concatenation in anonymous set Pablo Neira Ayuso
2021-06-14 11:34 ` Phil Sutter [this message]
2021-06-14 11:56 ` Pablo Neira Ayuso
2021-06-14 11:58 ` Pablo Neira Ayuso
2021-06-14 12:04 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614113403.GP22614@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).