From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39E6C2B9F4 for ; Mon, 14 Jun 2021 12:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7E62610A2 for ; Mon, 14 Jun 2021 12:41:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233025AbhFNMno (ORCPT ); Mon, 14 Jun 2021 08:43:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233023AbhFNMnn (ORCPT ); Mon, 14 Jun 2021 08:43:43 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE8ECC061574 for ; Mon, 14 Jun 2021 05:41:40 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1lsluM-0004fx-Sk; Mon, 14 Jun 2021 14:41:38 +0200 Date: Mon, 14 Jun 2021 14:41:38 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nftables] evaluate: add set to cache once Message-ID: <20210614124138.GQ22614@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20210614122454.27902-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614122454.27902-1-pablo@netfilter.org> Sender: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Mon, Jun 14, 2021 at 02:24:54PM +0200, Pablo Neira Ayuso wrote: > 67d3969a7244 ("evaluate: add set to the cache") re-adds the set into the > cache again. > > This bug was hidden behind 5ec5c706d993 ("cache: add hashtable cache for > table") which broken set_evaluate() for anonymous sets. > > Phil reported a gcc compilation warning which uncovered this problem. > > Reported-by: Phil Sutter > Fixes: 67d3969a7244 ("evaluate: add set to the cache") > Signed-off-by: Pablo Neira Ayuso Thanks for the quick fix! Out of curiosity, did you not use set_is_anonymous() in commit bbcc5eda7e588 on purpose? Cheers, Phil