From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9120C11F68 for ; Wed, 30 Jun 2021 15:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96EC7613ED for ; Wed, 30 Jun 2021 15:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236227AbhF3QBy (ORCPT ); Wed, 30 Jun 2021 12:01:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236159AbhF3QBC (ORCPT ); Wed, 30 Jun 2021 12:01:02 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A87C0613A3 for ; Wed, 30 Jun 2021 08:58:28 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lycba-0001ju-KM; Wed, 30 Jun 2021 17:58:26 +0200 Date: Wed, 30 Jun 2021 17:58:26 +0200 From: Florian Westphal To: Phil Sutter , Florian Westphal , netfilter-devel@vger.kernel.org, Pablo Neira Ayuso , Eric Garver Subject: Re: [PATCH nft v2 1/3] netlink_delinearize: add missing icmp id/sequence support Message-ID: <20210630155826.GE18022@breakpoint.cc> References: <20210615160151.10594-1-fw@strlen.de> <20210615160151.10594-2-fw@strlen.de> <20210630151319.GZ3673@orbyte.nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630151319.GZ3673@orbyte.nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > Eric reported a testcase in which this patch seems to cause a segfault > (bisected). The test is as simple as: I've pushed fix and a test case.