From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C028C4338F for ; Tue, 27 Jul 2021 19:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1615A60F91 for ; Tue, 27 Jul 2021 19:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230425AbhG0TzH (ORCPT ); Tue, 27 Jul 2021 15:55:07 -0400 Received: from mail.netfilter.org ([217.70.188.207]:36048 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbhG0TzG (ORCPT ); Tue, 27 Jul 2021 15:55:06 -0400 Received: from netfilter.org (bl11-146-165.dsl.telepac.pt [85.244.146.165]) by mail.netfilter.org (Postfix) with ESMTPSA id 794496411D; Tue, 27 Jul 2021 21:54:34 +0200 (CEST) Date: Tue, 27 Jul 2021 21:54:59 +0200 From: Pablo Neira Ayuso To: Kyle Bowman Cc: kernel-team@cloudflare.com, Alex Forster , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] netfilter: xt_NFLOG: allow 128 character log prefixes Message-ID: <20210727195459.GA15181@salvia> References: <20210727190001.914-1-kbowman@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210727190001.914-1-kbowman@cloudflare.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, On Tue, Jul 27, 2021 at 02:00:00PM -0500, Kyle Bowman wrote: > From: Alex Forster > > nftables defines NF_LOG_PREFIXLEN as 128 characters, while iptables > limits the NFLOG prefix to 64 characters. In order to eventually make > the two consistent [...] Why do you need to make the two consistent? iptables NFLOG prefix length is a subset of nftables log action, this is sufficient for the iptables-nft layer. I might be missing the use-case on your side, could you please elaborate?