From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FAFDC4338F for ; Tue, 27 Jul 2021 21:11:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D23460F94 for ; Tue, 27 Jul 2021 21:11:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231730AbhG0VLV (ORCPT ); Tue, 27 Jul 2021 17:11:21 -0400 Received: from mail.netfilter.org ([217.70.188.207]:36494 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231417AbhG0VLV (ORCPT ); Tue, 27 Jul 2021 17:11:21 -0400 Received: from netfilter.org (bl11-146-165.dsl.telepac.pt [85.244.146.165]) by mail.netfilter.org (Postfix) with ESMTPSA id 993E3605D7; Tue, 27 Jul 2021 23:10:50 +0200 (CEST) Date: Tue, 27 Jul 2021 23:11:16 +0200 From: Pablo Neira Ayuso To: Tom Yan Cc: netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [nft] Regarding `tcp flags` (and a potential bug) Message-ID: <20210727211116.GA13897@salvia> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Jul 27, 2021 at 10:52:39PM +0800, Tom Yan wrote: > Just noticed something that is even worse: > > # nft add rule meh tcp_flags 'tcp flags { fin, rst, ack }' > # nft add rule meh tcp_flags 'tcp flags == { fin, rst, ack }' > # nft add rule meh tcp_flags 'tcp flags & ( fin | rst | ack ) != 0' > # nft add rule meh tcp_flags 'tcp flags & ( fin | rst | ack ) == 0' > # nft list table meh > table ip meh { > chain tcp_flags { > tcp flags { fin, rst, ack } > tcp flags { fin, rst, ack } > tcp flags fin,rst,ack > tcp flags ! fin,rst,ack > } > } Could you develop the issue you're seeing here?