Re: [PATCH v3 1/2] netfilter: add new sysctl toggle for lightweight tunnel netfilter hooks

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3790 bytes --]

Hi Ryoga,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf-next/master]
[also build test ERROR on nf/master ipvs/master linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ryoga-Saito/netfilter-add-new-sysctl-toggle-for-lightweight-tunnel-netfilter-hooks/20210730-002403
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/c406e7bc7831acf318fd8217b94d2d9bc1f62deb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ryoga-Saito/netfilter-add-new-sysctl-toggle-for-lightweight-tunnel-netfilter-hooks/20210730-002403
        git checkout c406e7bc7831acf318fd8217b94d2d9bc1f62deb
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/static_key.h:1,
                    from arch/x86/include/asm/nospec-branch.h:6,
                    from arch/x86/include/asm/irqflags.h:9,
                    from include/linux/irqflags.h:16,
                    from include/linux/rcupdate.h:26,
                    from include/linux/sysctl.h:26,
                    from net/netfilter/nf_conntrack_lwtunnel.c:3:
   net/netfilter/nf_conntrack_lwtunnel.c: In function 'nf_conntrack_lwtunnel_get':
>> net/netfilter/nf_conntrack_lwtunnel.c:9:30: error: 'nf_ct_lwtunnel_enabled' undeclared (first use in this function)
       9 |  if (static_branch_unlikely(&nf_ct_lwtunnel_enabled))
         |                              ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:484:43: note: in definition of macro 'static_branch_unlikely'
     484 |  if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
         |                                           ^
   net/netfilter/nf_conntrack_lwtunnel.c:9:30: note: each undeclared identifier is reported only once for each function it appears in
       9 |  if (static_branch_unlikely(&nf_ct_lwtunnel_enabled))
         |                              ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:484:43: note: in definition of macro 'static_branch_unlikely'
     484 |  if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
         |                                           ^
   net/netfilter/nf_conntrack_lwtunnel.c: In function 'nf_conntrack_lwtunnel_set':
   net/netfilter/nf_conntrack_lwtunnel.c:17:30: error: 'nf_ct_lwtunnel_enabled' undeclared (first use in this function)
      17 |  if (static_branch_unlikely(&nf_ct_lwtunnel_enabled)) {
         |                              ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:484:43: note: in definition of macro 'static_branch_unlikely'
     484 |  if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
         |                                           ^


vim +/nf_ct_lwtunnel_enabled +9 net/netfilter/nf_conntrack_lwtunnel.c

     6	
     7	static inline int nf_conntrack_lwtunnel_get(void)
     8	{
   > 9		if (static_branch_unlikely(&nf_ct_lwtunnel_enabled))
    10			return 1;
    11		else
    12			return 0;
    13	}
    14	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29898 bytes --]