From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93BBC4338F for ; Mon, 9 Aug 2021 18:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C15DA60EE7 for ; Mon, 9 Aug 2021 18:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235341AbhHISqX (ORCPT ); Mon, 9 Aug 2021 14:46:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbhHISqX (ORCPT ); Mon, 9 Aug 2021 14:46:23 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76E5CC0613D3 for ; Mon, 9 Aug 2021 11:46:02 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mDAHf-0002Al-BL; Mon, 09 Aug 2021 20:45:59 +0200 Date: Mon, 9 Aug 2021 20:45:59 +0200 From: Florian Westphal To: Phil Sutter , Florian Westphal , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH RFC] scanner: nat: Move to own scope Message-ID: <20210809184559.GO607@breakpoint.cc> References: <20210809140141.18976-1-phil@nwl.cc> <20210809151833.GM607@breakpoint.cc> <20210809162514.GA3673@orbyte.nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809162514.GA3673@orbyte.nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > > So, it is in IP scope, sees 'prefix' (which will be STRING as the > > PREFIX scan rule is off) and that ends up in a parser error due to lack > > of a 'IP STRING' rule. > > OK, thanks. So does this mean we won't ever be able to move keywords > opening a statement or expression out of INIT scope or is my case a > special one? We can move them out of INIT scope, but only if they remain within the same scope. For example, you could create a 'rule scope' or 'expression scope' that contains all tokens (ip, tcp, etc.) that start a new expression. I did not do this because there are too many cases where expressions are permitted outside of rule scope, e.g. in set definitions (key, elements ...) > To clarify, what I have in mind is a sample rule 'ip id 1 tcp dport 1' > where 'tcp' must either be in INIT scope or part of SC_IP. IP and TCP need to be in the same scope (e.g. INIT). In the given example I suspect that TCP doesn't have to be in SC_IP scope since 'ip id 1' is a full expression and scope closure happens before next token gets scanned.