From: Kyle Bowman <kbowman@cloudflare.com>
To: netfilter-devel@vger.kernel.org
Cc: kernel-team@cloudflare.com, Kyle Bowman <kbowman@cloudflare.com>,
Alex Forster <aforster@cloudflare.com>,
Jeremy Sowden <jeremy@azazel.net>
Subject: [PATCH 3/3] extensions: libxf_NFLOG: remove `--nflog-range` Python unit-tests.
Date: Mon, 9 Aug 2021 14:42:43 -0500 [thread overview]
Message-ID: <20210809194243.53370-3-kbowman@cloudflare.com> (raw)
In-Reply-To: <20210809194243.53370-1-kbowman@cloudflare.com>
nft has no equivalent to `--nflog-range`, so we cannot emulate it and
the Python unit-tests for it fail. However, since `--nflog-range` is
broken and doesn't do anything, the tests are not testing anything
useful.
Signed-off-by: Kyle Bowman <kbowman@cloudflare.com>
Signed-off-by: Alex Forster <aforster@cloudflare.com>
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
extensions/libxt_NFLOG.t | 4 ----
1 file changed, 4 deletions(-)
diff --git a/extensions/libxt_NFLOG.t b/extensions/libxt_NFLOG.t
index 933fa221..33a15c06 100644
--- a/extensions/libxt_NFLOG.t
+++ b/extensions/libxt_NFLOG.t
@@ -3,10 +3,6 @@
-j NFLOG --nflog-group 65535;=;OK
-j NFLOG --nflog-group 65536;;FAIL
-j NFLOG --nflog-group 0;-j NFLOG;OK
--j NFLOG --nflog-range 1;=;OK
--j NFLOG --nflog-range 4294967295;=;OK
--j NFLOG --nflog-range 4294967296;;FAIL
--j NFLOG --nflog-range -1;;FAIL
-j NFLOG --nflog-size 0;=;OK
-j NFLOG --nflog-size 1;=;OK
-j NFLOG --nflog-size 4294967295;=;OK
--
2.20.1
next prev parent reply other threads:[~2021-08-09 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 19:42 [PATCH 1/3] extensions: libtxt_NFLOG: use nft built-in logging instead of xt_NFLOG Kyle Bowman
2021-08-09 19:42 ` [PATCH 2/3] extensions: libxt_NFLOG: dont truncate log prefix on print/save Kyle Bowman
2021-08-09 19:42 ` Kyle Bowman [this message]
2021-09-30 7:16 ` [PATCH 1/3] extensions: libtxt_NFLOG: use nft built-in logging instead of xt_NFLOG Jeremy Sowden
2021-09-30 20:04 ` Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809194243.53370-3-kbowman@cloudflare.com \
--to=kbowman@cloudflare.com \
--cc=aforster@cloudflare.com \
--cc=jeremy@azazel.net \
--cc=kernel-team@cloudflare.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).