From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next v2] netfilter: nf_queue: move hookfn registration out of struct net
Date: Tue, 10 Aug 2021 17:32:39 +0200 [thread overview]
Message-ID: <20210810153239.GA2636@salvia> (raw)
In-Reply-To: <20210805100243.21249-1-fw@strlen.de>
On Thu, Aug 05, 2021 at 12:02:43PM +0200, Florian Westphal wrote:
> This was done to detect when the pernet->init() function was not called
> yet, by checking if net->nf.queue_handler is NULL.
>
> Once the nfnetlink_queue module is active, all struct net pointers
> contain the same address. So place this back in nf_queue.c.
>
> Handle the 'netns error unwind' test by checking nfnl_queue_net for a
> NULL pointer and add a comment for this.
Applied, thanks.
prev parent reply other threads:[~2021-08-10 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 10:02 [PATCH nf-next v2] netfilter: nf_queue: move hookfn registration out of struct net Florian Westphal
2021-08-10 15:32 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810153239.GA2636@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).