From: Florian Westphal <fw@strlen.de>
To: alexandre.ferrieux@orange.com
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: nfnetlink_queue -- why linear lookup ?
Date: Sat, 14 Aug 2021 23:12:38 +0200 [thread overview]
Message-ID: <20210814211238.GH607@breakpoint.cc> (raw)
In-Reply-To: <14552_1628975094_61182FF6_14552_82_1_d4901cb2-0852-a524-436c-62bf06f95d0e@orange.com>
alexandre.ferrieux@orange.com <alexandre.ferrieux@orange.com> wrote:
> > Because when this was implemented "highly asynchronous" was not on the
> > radar. All users of this (that I know of) do in-order verdicts.
>
> So, O(N) instead of O(1) just because "I currently can't imagine N>5" ?
Seems so. THis code was written 21 years ago.
> Would a patch to that effect be rejected ?
Probably not, depends on the implementation.
next prev parent reply other threads:[~2021-08-14 21:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 11:55 nfnetlink_queue -- why linear lookup ? alexandre.ferrieux
2021-08-14 21:01 ` Florian Westphal
2021-08-14 21:05 ` alexandre.ferrieux
2021-08-14 21:12 ` Florian Westphal [this message]
2021-08-15 12:17 ` alexandre.ferrieux
2021-08-15 13:07 ` Pablo Neira Ayuso
2021-08-15 13:32 ` alexandre.ferrieux
2021-08-15 14:12 ` Pablo Neira Ayuso
2021-08-15 18:47 ` alexandre.ferrieux
2021-08-16 9:05 ` Pablo Neira Ayuso
2021-08-16 10:53 ` alexandre.ferrieux
2021-08-16 10:56 ` Florian Westphal
2021-08-16 11:07 ` alexandre.ferrieux
2021-08-16 11:19 ` Pablo Neira Ayuso
2021-08-16 11:42 ` Duncan Roe
2021-08-16 12:04 ` Duncan Roe
2021-08-16 16:10 ` Pablo Neira Ayuso
2021-08-16 16:15 ` Florian Westphal
2021-08-17 4:03 ` Duncan Roe
2021-08-15 13:33 ` alexandre.ferrieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210814211238.GH607@breakpoint.cc \
--to=fw@strlen.de \
--cc=alexandre.ferrieux@orange.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).