From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Jan Engelhardt <jengelh@inai.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptabes-nft] iptables-nft: allow removal of empty builtin chains
Date: Sun, 15 Aug 2021 15:12:23 +0200 [thread overview]
Message-ID: <20210815131223.GA30503@salvia> (raw)
In-Reply-To: <20210814205314.GF607@breakpoint.cc>
On Sat, Aug 14, 2021 at 10:53:14PM +0200, Florian Westphal wrote:
> Jan Engelhardt <jengelh@inai.de> wrote:
> >
> > On Saturday 2021-08-14 19:46, Florian Westphal wrote:
> > > Conservative change:
> > > iptables-nft -X will not remove empty builtin chains.
> > > OTOH, maybe it would be better to auto-remove those too, if empty.
> > > Comments?
> >
> > How are chain policies expressed in nft, as a property on the
> > chain (like legacy), or as a separate rule?
> > That is significant when removing "empty" chains.
>
> Indeed. Since this removes the base chain, it implicitly reverts
> a DROP policy too.
User still has to iptables -F on that given chain before deleting,
right?
If NLM_F_NONREC is used, the EBUSY is reported when trying to delete
a chain with rules.
My assumption is that the user will perform:
iptables-nft -F -t filter
iptables-nft -D -t filter
to follow the classic iptables-like approach (which requires usual -F
+ -X on every table).
I mean, by when the user has an empty basechain with default policy to
DROP, if they remove the chain, then they are really meaning to remove
the chain and this default policy to DROP.
Or am I missing anything else?
next prev parent reply other threads:[~2021-08-15 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 17:46 [PATCH iptabes-nft] iptables-nft: allow removal of empty builtin chains Florian Westphal
2021-08-14 20:18 ` Jan Engelhardt
2021-08-14 20:53 ` Florian Westphal
2021-08-15 13:12 ` Pablo Neira Ayuso [this message]
2021-08-15 13:27 ` Florian Westphal
2021-08-15 13:49 ` Pablo Neira Ayuso
2021-08-15 14:14 ` Florian Westphal
2021-08-15 14:27 ` Pablo Neira Ayuso
2021-08-15 14:36 ` Florian Westphal
2021-09-13 15:46 ` Phil Sutter
2021-09-13 16:02 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210815131223.GA30503@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).