From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37227C4338F for ; Sun, 15 Aug 2021 14:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D5156112E for ; Sun, 15 Aug 2021 14:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232907AbhHOO2K (ORCPT ); Sun, 15 Aug 2021 10:28:10 -0400 Received: from mail.netfilter.org ([217.70.188.207]:53434 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232465AbhHOO2J (ORCPT ); Sun, 15 Aug 2021 10:28:09 -0400 Received: from netfilter.org (unknown [78.30.35.141]) by mail.netfilter.org (Postfix) with ESMTPSA id 9A18B60052; Sun, 15 Aug 2021 16:26:52 +0200 (CEST) Date: Sun, 15 Aug 2021 16:27:34 +0200 From: Pablo Neira Ayuso To: Florian Westphal Cc: Jan Engelhardt , netfilter-devel@vger.kernel.org Subject: Re: [PATCH iptabes-nft] iptables-nft: allow removal of empty builtin chains Message-ID: <20210815142734.GA31050@salvia> References: <20210814174643.130760-1-fw@strlen.de> <84q02320-o5pp-8q8q-q646-473ssq92n552@vanv.qr> <20210814205314.GF607@breakpoint.cc> <20210815131223.GA30503@salvia> <20210815132733.GI607@breakpoint.cc> <20210815134922.GA10659@salvia> <20210815141414.GJ607@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210815141414.GJ607@breakpoint.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sun, Aug 15, 2021 at 04:14:14PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > But we really do not need NLM_F_NONREC for this new feature, right? I > > mean, a quick shortcut to remove the basechain and its content should > > be fine. > > Would deviate a lot from iptables behaviour. It's a new feature: you could still keep NLM_F_NONREC in place, and only allow to remove one chain (with no rules) at a time if you prefer, ie. iptables-nft -K INPUT -t filter or -X if you prefer to overload the existing command. > > > No, I don't think so. I would prefer if > > > iptables-nft -F -t filter > > > iptables-nft -X -t filter > > > > > > ... would result in an empty "filter" table. > > > > Your concern is that this would change the default behaviour? > > Yes, maybe ok to change it though. After all, a "iptables-nft -A INPUT > ..." will continue to work just fine (its auto-created again). > > We could check if policy is still set to accept before implicit > removal in the "iptables-nft -X" case. That's possible yes, but why force the user to change the policy from DROP to ACCEPT to delete an empty basechain right thereafter?