From: "Štěpán Němec" <snemec@redhat.com>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH iptables] iptables-test.py: print with color escapes only when stdout isatty
Date: Tue, 14 Sep 2021 11:03:42 +0200 [thread overview]
Message-ID: <20210914110342+0200.713702-snemec@redhat.com> (raw)
In-Reply-To: <20210913150533.GA22465@orbyte.nwl.cc>
On Mon, 13 Sep 2021 17:05:33 +0200
Phil Sutter wrote:
> Applied, thanks!
Thank you.
I see that you've pushed your series including the change to print error
messages to stdout [1] in the meantime.
I don't have a strong opinion on whether output of a script whose
(only?) purpose is to print diagnostic messages should go to stdout or
stderr, but I do think that having the "ERROR"s go to stderr and "OK"s
go to stdout is more confusing than useful: was that really intentional?
As a side effect of that change, my patch will act funny depending on
which output stream is being redirected, too.
(I'm sorry I haven't pointed this out earlier; I just skimmed your
patches and didn't notice this until double checking the conflict/merge
with my patch now.)
--
Štěpán
[1]
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20210906163038.15381-4-phil@nwl.cc/
next prev parent reply other threads:[~2021-09-14 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 11:33 [PATCH iptables] iptables-test.py: print with color escapes only when stdout isatty Štěpán Němec
2021-09-03 12:52 ` Phil Sutter
2021-09-03 14:44 ` Štěpán Němec
2021-09-03 15:34 ` Phil Sutter
2021-09-06 9:04 ` Štěpán Němec
2021-09-13 15:05 ` Phil Sutter
2021-09-14 9:03 ` Štěpán Němec [this message]
2021-09-14 11:25 ` Phil Sutter
2021-09-14 11:49 ` Štěpán Němec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914110342+0200.713702-snemec@redhat.com \
--to=snemec@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).