From: "Štěpán Němec" <snemec@redhat.com>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH iptables] iptables-test.py: print with color escapes only when stdout isatty
Date: Tue, 14 Sep 2021 13:49:26 +0200 [thread overview]
Message-ID: <20210914134926+0200.802182-snemec@redhat.com> (raw)
In-Reply-To: <20210914112516.GA26723@orbyte.nwl.cc>
On Tue, 14 Sep 2021 13:25:16 +0200
Phil Sutter wrote:
> Printing errors to stderr is useful to compare failing tests against an
> expected set of failures - it is simply a task of comparing output on
> stderr with a recorded one.
I see. I'm still not sure the expected convenience factor (avoiding some
grep-like post processing? but couldn't you compare the combined output
just the same?) outweighs the weirdness / least surprise factor (having
two variations of the same diagnostic message split on two separate
output streams).
> To not overcomplicate things, maybe the easiest fix would be to print
> colors only if both stdout and stderr are a tty. What do you think?
Yes, if the split has to stay, I don't have a better suggestion.
Thanks,
Štěpán
prev parent reply other threads:[~2021-09-14 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 11:33 [PATCH iptables] iptables-test.py: print with color escapes only when stdout isatty Štěpán Němec
2021-09-03 12:52 ` Phil Sutter
2021-09-03 14:44 ` Štěpán Němec
2021-09-03 15:34 ` Phil Sutter
2021-09-06 9:04 ` Štěpán Němec
2021-09-13 15:05 ` Phil Sutter
2021-09-14 9:03 ` Štěpán Němec
2021-09-14 11:25 ` Phil Sutter
2021-09-14 11:49 ` Štěpán Němec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914134926+0200.802182-snemec@redhat.com \
--to=snemec@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).