From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH nft] evaluate: provide a hint on missing dynamic flag
Date: Sat, 25 Sep 2021 22:46:25 +0200 [thread overview]
Message-ID: <20210925204625.22803-1-pablo@netfilter.org> (raw)
Provide a hint to users if they forget to set on the dynamic flag, if
such set is updated from the packet path.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/evaluate.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/evaluate.c b/src/evaluate.c
index 8ebc75617b1c..a0c67fb0e213 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -3598,6 +3598,11 @@ static int stmt_evaluate_set(struct eval_ctx *ctx, struct stmt *stmt)
return expr_error(ctx->msgs, stmt->set.set,
"Expression does not refer to a set");
+ if (!(stmt->set.set->set->flags & NFT_SET_EVAL))
+ return expr_error(ctx->msgs, stmt->set.set,
+ "%s does not allow for dynamic updates, add 'flags dynamic' to your set declaration",
+ stmt->set.set->set->flags & NFT_SET_MAP ? "map" : "set");
+
if (stmt_evaluate_arg(ctx, stmt,
stmt->set.set->set->key->dtype,
stmt->set.set->set->key->len,
--
2.30.2
reply other threads:[~2021-09-25 20:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925204625.22803-1-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).