* [PATCH nft] evaluate: provide a hint on missing dynamic flag
@ 2021-09-25 20:46 Pablo Neira Ayuso
0 siblings, 0 replies; only message in thread
From: Pablo Neira Ayuso @ 2021-09-25 20:46 UTC (permalink / raw)
To: netfilter-devel
Provide a hint to users if they forget to set on the dynamic flag, if
such set is updated from the packet path.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/evaluate.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/evaluate.c b/src/evaluate.c
index 8ebc75617b1c..a0c67fb0e213 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -3598,6 +3598,11 @@ static int stmt_evaluate_set(struct eval_ctx *ctx, struct stmt *stmt)
return expr_error(ctx->msgs, stmt->set.set,
"Expression does not refer to a set");
+ if (!(stmt->set.set->set->flags & NFT_SET_EVAL))
+ return expr_error(ctx->msgs, stmt->set.set,
+ "%s does not allow for dynamic updates, add 'flags dynamic' to your set declaration",
+ stmt->set.set->set->flags & NFT_SET_MAP ? "map" : "set");
+
if (stmt_evaluate_arg(ctx, stmt,
stmt->set.set->set->key->dtype,
stmt->set.set->set->key->len,
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-25 20:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-25 20:46 [PATCH nft] evaluate: provide a hint on missing dynamic flag Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).