From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B367DC433EF for ; Thu, 7 Oct 2021 19:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96954610C8 for ; Thu, 7 Oct 2021 19:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232709AbhJGTyw (ORCPT ); Thu, 7 Oct 2021 15:54:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233845AbhJGTyv (ORCPT ); Thu, 7 Oct 2021 15:54:51 -0400 Received: from kadath.azazel.net (kadath.azazel.net [IPv6:2001:8b0:135f:bcd1:e0cb:4eff:fedf:e608]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFB69C061762 for ; Thu, 7 Oct 2021 12:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=azazel.net; s=20190108; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NOYI16mwpUDe2BEb6dPA5s3hUXvmdyzi8a3frNA+2qA=; b=TY4CEAN9b1EoTrWnv9hcw4lctN hs6yYtnhJ4qGAwcB+U2gTanN+2hfa5iaqaXyYS6fh/ctj4Ug1+Un9A5zDwYQe5Iyxf+mm/Gb2qdC+ DhcTSZ08uxxKcqYJ3EE8f+ZC7MCS4YEwnKYjOpG2hsFMwi+KYdN55GepjFx3+xJp02LxO1UNd9iAD o7a0BzVqf23wC1Z66/z2chKaJo/b7WAM88hUGIju8oL/BL7JCvo6oN0bvZt9l3jIxTU9zVivE7ylG uTzWs2D97eitYTP7T5dj+/wVVgpyzJ3aEXn+yL+XM02StgNwjHewtLggljpjT6kZwiyHaJnfxmEkz JYtT7eDg==; Received: from ulthar.dreamlands.azazel.net ([2001:8b0:fb7d:d6d7:2e4d:54ff:fe4b:a9ae]) by kadath.azazel.net with esmtp (Exim 4.94.2) (envelope-from ) id 1mYZRj-009WeN-LN for netfilter-devel@vger.kernel.org; Thu, 07 Oct 2021 20:52:51 +0100 From: Jeremy Sowden To: Netfilter Devel Subject: [nft PATCH v2 3/3] rule: replace three conditionals with one. Date: Thu, 7 Oct 2021 20:49:02 +0100 Message-Id: <20211007194902.2613579-4-jeremy@azazel.net> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211007194902.2613579-1-jeremy@azazel.net> References: <20211007194902.2613579-1-jeremy@azazel.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:8b0:fb7d:d6d7:2e4d:54ff:fe4b:a9ae X-SA-Exim-Mail-From: jeremy@azazel.net X-SA-Exim-Scanned: No (on kadath.azazel.net); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org When outputting set definitions, merge three consecutive `if (!list_empty(&set->stmt_list))` conditionals. Signed-off-by: Jeremy Sowden --- src/rule.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/rule.c b/src/rule.c index b566adf07b1f..7c048fcc1eee 100644 --- a/src/rule.c +++ b/src/rule.c @@ -366,12 +366,11 @@ static void set_print_declaration(const struct set *set, nft_print(octx, "%s", opts->stmt_separator); } - if (!list_empty(&set->stmt_list)) - nft_print(octx, "%s%s", opts->tab, opts->tab); - if (!list_empty(&set->stmt_list)) { unsigned int flags = octx->flags; + nft_print(octx, "%s%s", opts->tab, opts->tab); + octx->flags |= NFT_CTX_OUTPUT_STATELESS; list_for_each_entry(stmt, &set->stmt_list, list) { stmt_print(stmt, octx); @@ -379,10 +378,9 @@ static void set_print_declaration(const struct set *set, nft_print(octx, " "); } octx->flags = flags; - } - if (!list_empty(&set->stmt_list)) nft_print(octx, "%s", opts->stmt_separator); + } if (set->automerge) nft_print(octx, "%s%sauto-merge%s", opts->tab, opts->tab, -- 2.33.0