netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Štěpán Němec" <snemec@redhat.com>
To: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: [PATCH nft 1/3] tests: shell: README: copy edit
Date: Wed, 20 Oct 2021 14:45:10 +0200	[thread overview]
Message-ID: <20211020124512.490288-1-snemec@redhat.com> (raw)

Signed-off-by: Štěpán Němec <snemec@redhat.com>
---
 tests/shell/README | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/tests/shell/README b/tests/shell/README
index e0279bbdc30c..35f6e3785f0e 100644
--- a/tests/shell/README
+++ b/tests/shell/README
@@ -1,16 +1,17 @@
-This test-suite is intended to perform tests of higher level than
-the other regression test-suite.
+This test suite is intended to perform tests on a higher level
+than the other regression test suites.
 
-It can run arbitrary executables which can perform any test apart of testing
-the nft syntax or netlink code (which is what the regression tests does).
+It can run arbitrary executables which can perform any test, not
+limited to testing the nft syntax or netlink code (which is what
+the regression tests do).
 
 To run the test suite (as root):
  $ cd tests/shell
  # ./run-tests.sh
 
-Test files are executables files with the pattern <<name_N>>, where N is the
-expected return code of the executable. Since they are located with `find',
-test-files can be spread in any sub-directories.
+Test files are executable files matching the pattern <<name_N>>,
+where N is the expected return code of the executable. Since they
+are located with `find', test files can be put in any subdirectory.
 
 You can turn on a verbose execution by calling:
  # ./run-tests.sh -v
@@ -18,11 +19,11 @@ You can turn on a verbose execution by calling:
 And generate missing dump files with:
  # ./run-tests.sh -g <TESTFILE>
 
-Before each call to the test-files, `nft flush ruleset' will be called.
-Also, test-files will receive the environment variable $NFT which contains the
-path to the nftables binary being tested.
+Before each test file invocation, `nft flush ruleset' will be called.
+Also, test file process environment will include the variable $NFT
+which contains the path to the nft binary being tested.
 
 You can pass an arbitrary $NFT value as well:
  # NFT=/usr/local/sbin/nft ./run-tests.sh
 
-By default the tests are run with the nft binary at '../../src/nft'
+By default, the tests are run with the nft binary at '../../src/nft'

base-commit: 2139913694a9850c9160920b2c638aac4828f9bb
-- 
2.33.1


             reply	other threads:[~2021-10-20 12:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 12:45 Štěpán Němec [this message]
2021-10-20 12:45 ` [PATCH nft 2/3] tests: shell: README: $NFT does not have to be a path to a binary Štěpán Němec
2021-10-20 12:45 ` [PATCH nft 3/3] tests: shell: README: clarify test file name convention Štěpán Němec
2021-10-20 15:04 ` [PATCH nft 1/3] tests: shell: README: copy edit Phil Sutter
2021-10-21  8:30   ` Štěpán Němec
2021-10-21 10:26     ` Phil Sutter
2021-10-21 11:03       ` Štěpán Němec
2021-10-27  9:06         ` Pablo Neira Ayuso
2021-10-27  9:51           ` Štěpán Němec
2021-10-27 10:13             ` Pablo Neira Ayuso
2021-10-27 11:04               ` Štěpán Němec
2021-10-27 19:07                 ` Pablo Neira Ayuso
2021-11-05 11:39                   ` [PATCH nft v2 1/4] " Štěpán Němec
2021-11-05 11:39                     ` [PATCH nft v2 2/4] tests: shell: README: $NFT does not have to be a path to a binary Štěpán Němec
2021-11-05 11:39                     ` [PATCH nft v2 3/4] tests: shell: README: clarify test file name convention Štěpán Němec
2021-11-05 11:39                     ` [PATCH nft v2 4/4] tests: shell: $NFT needs to be invoked unquoted Štěpán Němec
2021-11-05 13:22                     ` [PATCH nft v2 1/4] tests: shell: README: copy edit Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020124512.490288-1-snemec@redhat.com \
    --to=snemec@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).